[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v3 0/6] target-arm: Fix Neon shift instructions.
From: |
Peter Maydell |
Subject: |
Re: [Qemu-devel] [PATCH v3 0/6] target-arm: Fix Neon shift instructions. |
Date: |
Tue, 15 Feb 2011 14:21:14 +0000 |
On 15 February 2011 14:03, Christophe Lyon <address@hidden> wrote:
> It also seems that the neon_shl_s* helpers don't handle correctly large
> negative shift amounts.
They look OK to me (large -ve shift is a huge right shift,
which for signed values should propagate the sign bit
to all bit positions, so we shift-right by typesize - 1),
and I didn't see any problems with them when I was
doing my testing. What do you think they get wrong?
-- PMM
- Re: [Qemu-devel] [PATCH 1/6] target-arm: Fix rounding constant addition for Neon shift instructions., (continued)