Re: [Qemu-devel] [PATCH 08/11] Add scoop post_load callback that sets IRQs to loaded levels

[Dmitry Eremin-Solenikov]

On 2/11/11, andrzej zaborowski <address@hidden> wrote:
> Hi Dmitry,
>
> On 31 January 2011 16:20, Dmitry Eremin-Solenikov <address@hidden>
> wrote:
>> Signed-off-by: Dmitry Eremin-Solenikov <address@hidden>
>> ---
>>  hw/zaurus.c |   19 ++++++++++++++++++-
>>  1 files changed, 18 insertions(+), 1 deletions(-)
>>
>> diff --git a/hw/zaurus.c b/hw/zaurus.c
>> index fca11a5..90fedc9 100644
>> --- a/hw/zaurus.c
>> +++ b/hw/zaurus.c
>> @@ -181,17 +181,34 @@ static int scoop_init(SysBusDevice *dev)
>>     return 0;
>>  }
>>
>> +static int scoop_post_load(void *opaque, int version_id)
>> +{
>> +    ScoopInfo *s = (ScoopInfo *) opaque;
>> +    int i;
>> +    uint32_t level;
>> +
>> +    level = s->gpio_level & s->gpio_dir;
>> +
>> +    for (i = 1; i < 1 << 16; i <<= 1) {
>> +        qemu_set_irq(s->handler[i], level & i);
>
> This looks like it's going to try to set s->handler[1] up to
> s->handler[32k] (should be 0 to 15), otherwise this patch is a good
> catch.

Oops. Fixed in a resent patch.


-- 
With best wishes
Dmitry