[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH] target-arm: fix VQMOVUN Neon instruction.
From: |
Peter Maydell |
Subject: |
Re: [Qemu-devel] [PATCH] target-arm: fix VQMOVUN Neon instruction. |
Date: |
Wed, 9 Feb 2011 15:50:07 +0000 |
On 9 February 2011 12:47, Christophe Lyon <address@hidden> wrote:
>
> Create and use neon_unarrow_sat* helpers.
>
> Signed-off-by: Christophe Lyon <address@hidden>
This is OK code-wise, but since it has come from the meego tree it
ought to have Juha's sign-off rather than yours. Also the commit
message was another of the terse placeholder ones I put in when
I was splitting up a huge meego patch into subsections and isn't
really (IMHO) descriptive enough for upstream.
I've corrected this in the patchset I've just sent (which includes a
fix for another bug which is needed for the VQMOV(U)N/VMOVN
set to pass random input testing.)
thanks
-- PMM