[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-devel] Re: [PATCH 02/15] Refactor cpu_has_work/any_cpu_has_work in
From: |
Marcelo Tosatti |
Subject: |
[Qemu-devel] Re: [PATCH 02/15] Refactor cpu_has_work/any_cpu_has_work in cpus.c |
Date: |
Wed, 9 Feb 2011 11:54:16 -0200 |
User-agent: |
Mutt/1.5.20 (2009-08-17) |
On Wed, Feb 09, 2011 at 09:07:50AM +0100, Jan Kiszka wrote:
> > Do you really find it easier to read evaluations grouped with || ? I
> > don't.
>
> I do, specifically as the old version was even more confusing in that
> important detail "return 0" vs. "return 1". But even the new benefits
> from the grouping IMHO.
Well alright.
> > Sorry but the name change does not feel right either: CPU is still idle
> > if the vm is not running.
>
> But that's exactly what the function returns. Or is it confusing if we
> are talking about the vcpu or the whole thread here? What about
> "cpu_thread_is_idle" then?
Yes thats better.
Re: [Qemu-devel] [PATCH 15/15] kvm: x86: Introduce kvmclock device to save/restore its state, Blue Swirl, 2011/02/07
[Qemu-devel] [PATCH 02/15] Refactor cpu_has_work/any_cpu_has_work in cpus.c, Jan Kiszka, 2011/02/07
[Qemu-devel] [PATCH v2 02/15] Refactor cpu_has_work/any_cpu_has_work in cpus.c, Jan Kiszka, 2011/02/09