|
From: | Avi Kivity |
Subject: | Re: [Qemu-devel] Re: [RFC: 0/2] patch for QEMU HPET periodic timer emulation to alleviate time drift |
Date: | Tue, 08 Feb 2011 11:11:39 +0200 |
User-agent: | Mozilla/5.0 (X11; U; Linux x86_64; en-US; rv:1.9.2.13) Gecko/20101209 Fedora/3.1.7-0.35.b3pre.fc14 Lightning/1.0b3pre Thunderbird/3.1.7 |
On 02/07/2011 09:30 PM, Anthony Liguori wrote:
For the purposes of this, I think passing an opaque is better because the signature stays the same as the existing timer callback. That makes conversion a bit friendlier.I think it's better to avoid introducing stylistic changes with new interfaces. I think they should be done separately.
Suppose I convert all 100-odd QEMUTimer users to the new style? Might be a good exercise for Coccinelle.
-- error compiling committee.c: too many arguments to function
[Prev in Thread] | Current Thread | [Next in Thread] |