[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH REBASE/RESEND 0/4] Auto-document qdev devices
From: |
Markus Armbruster |
Subject: |
Re: [Qemu-devel] [PATCH REBASE/RESEND 0/4] Auto-document qdev devices |
Date: |
Fri, 04 Feb 2011 09:02:22 +0100 |
User-agent: |
Gnus/5.13 (Gnus v5.13) Emacs/23.1 (gnu/linux) |
Amit Shah <address@hidden> writes:
> Hello,
>
> This is yet another rebase of the patchset I'd sent earlier.
>
> The usual notes apply: this is just the start, just getting the
> framework in place and a few examples so that people can then pick up
> and start documenting their devices and options. We want to see all
> of the devices covered, and hopefully turn on build_bug_on() on an
> empty doc string.
>
> Maintainers should perhaps also look for patches that introduce
> options without documentation.
>
> That's the long-term goal (0.15-final). For short-term, I'll be
> preparing follow-on patches that add doc strings for a few more
> options and perhaps bug people based on git history as to what
> documentation is to be added for some options. Also to incorporate
> Markus's comments on beautifying output.
>
> The earlier this patchset goes in the better since it'll reduce
> conflicts and rebases needed.
>
> If this looks acceptable, please apply!
As long as Amit keeps rebasing his patches, I'll keep resending my
comment (it does get old, though):
This has been stuck since forever. No idea why, it's neither hairy nor
controversial.
Quoting from my review of v2(?) last September:
For QMP, we'll need to cover more than just device properties, and
in more detail than just a help text, but this looks like a sensible
step forward.
I'm fine with committing it as is. We can polish in follow-up commits.
- [Qemu-devel] [PATCH REBASE/RESEND 1/4] qdev: Add a description field for qdev properties for documentation, (continued)
- [Qemu-devel] [PATCH REBASE/RESEND 1/4] qdev: Add a description field for qdev properties for documentation, Amit Shah, 2011/02/04
- Re: [Qemu-devel] [PATCH REBASE/RESEND 1/4] qdev: Add a description field for qdev properties for documentation, Anthony Liguori, 2011/02/15
- Re: [Qemu-devel] [PATCH REBASE/RESEND 1/4] qdev: Add a description field for qdev properties for documentation, Amit Shah, 2011/02/17
- Re: [Qemu-devel] [PATCH REBASE/RESEND 1/4] qdev: Add a description field for qdev properties for documentation, Anthony Liguori, 2011/02/17
- Re: [Qemu-devel] [PATCH REBASE/RESEND 1/4] qdev: Add a description field for qdev properties for documentation, Amit Shah, 2011/02/17
- Re: [Qemu-devel] [PATCH REBASE/RESEND 1/4] qdev: Add a description field for qdev properties for documentation, Markus Armbruster, 2011/02/18
- Re: [Qemu-devel] [PATCH REBASE/RESEND 1/4] qdev: Add a description field for qdev properties for documentation, Anthony Liguori, 2011/02/18
- Re: [Qemu-devel] [PATCH REBASE/RESEND 1/4] qdev: Add a description field for qdev properties for documentation, Markus Armbruster, 2011/02/18
[Qemu-devel] [PATCH REBASE/RESEND 3/4] net.h: Add description fields for qdev properites, Amit Shah, 2011/02/04
[Qemu-devel] [PATCH REBASE/RESEND 4/4] block_int.h: Provide documentation for common block qdev properties, Amit Shah, 2011/02/04
Re: [Qemu-devel] [PATCH REBASE/RESEND 0/4] Auto-document qdev devices,
Markus Armbruster <=
Re: [Qemu-devel] [PATCH REBASE/RESEND 0/4] Auto-document qdev devices, Anthony Liguori, 2011/02/15