[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-devel] Re: [PATCH 19/19] migration: add a parser to accept FT migr
From: |
Yoshiaki Tamura |
Subject: |
[Qemu-devel] Re: [PATCH 19/19] migration: add a parser to accept FT migration incoming mode. |
Date: |
Fri, 28 Jan 2011 22:53:23 +0900 |
2011/1/28 Paolo Bonzini <address@hidden>:
> On 01/28/2011 08:21 AM, Yoshiaki Tamura wrote:
>>
>> + /* check ft_mode option */
>> + p = strstr(uri, "ft_mode");
>> + if (p&& !strcmp(p, "ft_mode")) {
>> + ft_mode = FT_INIT;
>> + }
>> +
>
> This works for TCP mode, but:
>
> 1) I am not sure what would happen with -incoming exec;
Nothing happens if used with other protocols, but I assume you're
mentioning that it's not clear from the code, which makes sense.
> 2) it is tricky! :) It works only because anything after the port is
> truncated by parse_host_port.
>
> Is there any reason why the code cannot be in tcp_start_incoming_migration,
> where we know the URI has the right scheme? Alternatively you could put it
> _before_ the scheme, like "kemari:tcp:host:port".
I placed it here just because string parsing was mainly done in
this function except for parse_host_port. I have no objection
placing the parsing at the beginning of
tcp_start_incoming_migration.
Thanks,
Yoshi
>
> Paolo
> --
> To unsubscribe from this list: send the line "unsubscribe kvm" in
> the body of a message to address@hidden
> More majordomo info at http://vger.kernel.org/majordomo-info.html
>
- [Qemu-devel] [PATCH 14/19] block: insert event-tap to bdrv_aio_writev(), bdrv_aio_flush() and bdrv_flush()., (continued)
- [Qemu-devel] [PATCH 14/19] block: insert event-tap to bdrv_aio_writev(), bdrv_aio_flush() and bdrv_flush()., Yoshiaki Tamura, 2011/01/28
- [Qemu-devel] [PATCH 10/19] Call init handler of event-tap at main() in vl.c., Yoshiaki Tamura, 2011/01/28
- [Qemu-devel] [PATCH 02/19] Introduce read() to FdMigrationState., Yoshiaki Tamura, 2011/01/28
- [Qemu-devel] [PATCH 17/19] migration-tcp: modify tcp_accept_incoming_migration() to handle ft_mode, and add a hack not to close fd when ft_mode is enabled., Yoshiaki Tamura, 2011/01/28
- [Qemu-devel] [PATCH 05/19] vl.c: add deleted flag for deleting the handler., Yoshiaki Tamura, 2011/01/28
- [Qemu-devel] [PATCH 03/19] Introduce skip_header parameter to qemu_loadvm_state()., Yoshiaki Tamura, 2011/01/28
- [Qemu-devel] [PATCH 01/19] Make QEMUFile buf expandable, and introduce qemu_realloc_buffer() and qemu_clear_buffer()., Yoshiaki Tamura, 2011/01/28
- [Qemu-devel] [PATCH 19/19] migration: add a parser to accept FT migration incoming mode., Yoshiaki Tamura, 2011/01/28
- [Qemu-devel] Re: [PATCH 19/19] migration: add a parser to accept FT migration incoming mode., Paolo Bonzini, 2011/01/28
- [Qemu-devel] Re: [PATCH 19/19] migration: add a parser to accept FT migration incoming mode.,
Yoshiaki Tamura <=
- [Qemu-devel] Re: [PATCH 19/19] migration: add a parser to accept FT migration incoming mode., Paolo Bonzini, 2011/01/28
- Re: [Qemu-devel] Re: [PATCH 19/19] migration: add a parser to accept FT migration incoming mode., Yoshiaki Tamura, 2011/01/28
- Re: [Qemu-devel] Re: [PATCH 19/19] migration: add a parser to accept FT migration incoming mode., Paolo Bonzini, 2011/01/28
- Re: [Qemu-devel] Re: [PATCH 19/19] migration: add a parser to accept FT migration incoming mode., Yoshiaki Tamura, 2011/01/28
- Re: [Qemu-devel] Re: [PATCH 19/19] migration: add a parser to accept FT migration incoming mode., Paolo Bonzini, 2011/01/28
- Re: [Qemu-devel] Re: [PATCH 19/19] migration: add a parser to accept FT migration incoming mode., Yoshiaki Tamura, 2011/01/29
- Re: [Qemu-devel] Re: [PATCH 19/19] migration: add a parser to accept FT migration incoming mode., Paolo Bonzini, 2011/01/29
- Re: [Qemu-devel] Re: [PATCH 19/19] migration: add a parser to accept FT migration incoming mode., Yoshiaki Tamura, 2011/01/29
- Re: [Qemu-devel] Re: [PATCH 19/19] migration: add a parser to accept FT migration incoming mode., Paolo Bonzini, 2011/01/29
- Re: [Qemu-devel] Re: [PATCH 19/19] migration: add a parser to accept FT migration incoming mode., Yoshiaki Tamura, 2011/01/29