qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] Re: Commit 622b520f changed -drive if=scsi, index=N, i


From: Gerd Hoffmann
Subject: Re: [Qemu-devel] Re: Commit 622b520f changed -drive if=scsi, index=N, intentional?
Date: Thu, 27 Jan 2011 20:26:02 +0100
User-agent: Mozilla/5.0 (X11; U; Linux x86_64; en-US; rv:1.9.2.13) Gecko/20101208 Red Hat/3.1.7-3.el6_0 Thunderbird/3.1.7

  Hi,

          } else if (!strcmp(buf, "scsi")) {
             type = IF_SCSI;
-            max_devs = MAX_SCSI_DEVS;
+            max_devs = 7;

That's very obviously not much more than a hack, but I don't think
blockdev.c can get the real number easily (please prove me wrong). With
this hack, we would get the old behaviour for -drive (which doesn't use
any other controller anyway) and you can still use -device to attach
more devices to a non-lsi bus.

Looks sensible to me. scsi controllers with more than 7 devs (megasas and whatever else might be coming, virtio?) can't be added via if=scsi legacy syntax and must use -blockdev and -device anyway.

We probably want add a comment explaining this though.

cheers,
  Gerd



reply via email to

[Prev in Thread] Current Thread [Next in Thread]