qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] Re: [PATCH v4 0/4] strtosz() cleanups


From: Jes Sorensen
Subject: Re: [Qemu-devel] Re: [PATCH v4 0/4] strtosz() cleanups
Date: Tue, 25 Jan 2011 12:52:20 +0100
User-agent: Mozilla/5.0 (X11; U; Linux x86_64; en-US; rv:1.9.2.13) Gecko/20101209 Fedora/3.1.7-0.35.b3pre.fc14 Lightning/1.0b3pre Thunderbird/3.1.7

On 01/25/11 11:14, Markus Armbruster wrote:
> Jes Sorensen <address@hidden> writes:
> 
>> On 01/24/11 18:28, Stefan Weil wrote:
>>> There was some discussion regarding this patch set.
>>> I agree with Markus that part of the first patch
>>> should be removed: don't change char to unsigned char.
>>
>> The unsigned char should definitely go in, leaving it as a signed char
>> doesn't serve any purpose.
> 
> Leaving something as is doesn't need justification.  Changing it does.
> The justification presented so far was "it is prettier to match the real
> behavior of pure toupper()".  Which I don't buy.  But without commit
> access, I'm not a buyer.

Well that is just too bad. qemu_toupper() is a hack around the fact that
people often forget to use the right type, it is not an excuse for using
the wrong type in the code.

Jes



reply via email to

[Prev in Thread] Current Thread [Next in Thread]