[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-devel] Re: [RFC][PATCH v6 07/23] virtagent: base server definition
From: |
Jes Sorensen |
Subject: |
[Qemu-devel] Re: [RFC][PATCH v6 07/23] virtagent: base server definitions |
Date: |
Fri, 21 Jan 2011 17:38:00 +0100 |
User-agent: |
Mozilla/5.0 (X11; U; Linux x86_64; en-US; rv:1.9.2.13) Gecko/20101209 Fedora/3.1.7-0.35.b3pre.fc14 Lightning/1.0b3pre Thunderbird/3.1.7 |
> diff --git a/virtagent-server.h b/virtagent-server.h
> new file mode 100644
> index 0000000..9f68921
> --- /dev/null
> +++ b/virtagent-server.h
> @@ -0,0 +1,34 @@
> +/*
> + * virt-agent - host/guest RPC daemon functions
> + *
> + * Copyright IBM Corp. 2010
> + *
> + * Authors:
> + * Michael Roth <address@hidden>
> + *
> + * This work is licensed under the terms of the GNU GPL, version 2 or later.
> + * See the COPYING file in the top-level directory.
> + *
> + */
> +
> +#include <xmlrpc-c/base.h>
> +#include <xmlrpc-c/server.h>
> +
> +#define GUEST_AGENT_SERVICE_ID "virtagent"
> +#define GUEST_AGENT_PATH "/tmp/virtagent-guest.sock"
> +#define HOST_AGENT_SERVICE_ID "virtagent-host"
> +#define HOST_AGENT_PATH "/tmp/virtagent-host.sock"
> +#define VA_GETFILE_MAX 1 << 30
> +#define VA_FILEBUF_LEN 16384
> +#define VA_DMESG_LEN 16384
I really don't like these hard coded constants - you you have a command
line interface allowing for the change of the sockets and file names?
Otherwise you'll hit problems on the host side with concurrent runs of qemu.
I really would like to see the dmesg stuff removed too for now as we
discussed earlier.
Cheers,
Jes
- [Qemu-devel] [RFC][PATCH v6 03/23] Make qemu timers available for tools, (continued)
- [Qemu-devel] [RFC][PATCH v6 06/23] virtagent: base client definitions, Michael Roth, 2011/01/17
- [Qemu-devel] [RFC][PATCH v6 04/23] virtagent: common code for managing client/server rpc jobs, Michael Roth, 2011/01/17
- [Qemu-devel] [RFC][PATCH v6 05/23] virtagent: transport definitions read/send callback functions, Michael Roth, 2011/01/17
- [Qemu-devel] [RFC][PATCH v6 09/23] virtagent: add agent_viewfile qmp/hmp command, Michael Roth, 2011/01/17
- [Qemu-devel] [RFC][PATCH v6 07/23] virtagent: base server definitions, Michael Roth, 2011/01/17
- [Qemu-devel] Re: [RFC][PATCH v6 07/23] virtagent: base server definitions,
Jes Sorensen <=
[Qemu-devel] [RFC][PATCH v6 12/23] virtagent: add va.shutdown RPC, Michael Roth, 2011/01/17
[Qemu-devel] [RFC][PATCH v6 11/23] virtagent: add agent_viewdmesg qmp/hmp commands, Michael Roth, 2011/01/17
[Qemu-devel] [RFC][PATCH v6 08/23] virtagent: add va.getfile RPC, Michael Roth, 2011/01/17