[Qemu-devel] Re: [PATCH v3 0/4] usb-msd: Add usb-storage, removable=on|off property

[Kevin Wolf]

Am 21.01.2011 12:00, schrieb Stefan Hajnoczi:
> Allow overriding the SCSI INQUIRY removable (RMB) bit for scsi-disk and 
> usb-msd
> devices.  In particular this addresses the problem that some usb-msd devices
> have the bit set while other do not have it set.  Now the user can choose and
> get desired guest behavior.
> 
> qemu -usb
>      -drive if=none,file=test.img,cache=none,id=disk0
>      -device usb-storage,drive=disk0,removable=on
> 
> The default is off.
> 
> v3:
>  * Document removable property in qdev-device-use.txt
>  * Use bit number 0 instead of bit 1 for the qdev property
> 
> v2:
>  * Rewritten to override the bit at the scsi-disk level
> 
>  docs/qdev-device-use.txt |   13 +++++++++++--
>  hw/pci-hotplug.c         |    2 +-
>  hw/scsi-bus.c            |    8 ++++++--
>  hw/scsi-disk.c           |    3 +++
>  hw/scsi.h                |    3 ++-
>  hw/usb-msd.c             |    4 +++-
>  6 files changed, 26 insertions(+), 7 deletions(-)

Thanks, applied all to the block branch.

Kevin