[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-devel] Re: [PATCH v2 0/2] strtosz() cleanup
From: |
Alex Williamson |
Subject: |
[Qemu-devel] Re: [PATCH v2 0/2] strtosz() cleanup |
Date: |
Mon, 17 Jan 2011 08:24:27 -0700 |
On Mon, 2011-01-17 at 16:14 +0100, address@hidden wrote:
> From: Jes Sorensen <address@hidden>
>
> Fix issue with signed char and isspace() as well as clean up switch
> statement using toupper().
>
> V2 of the patch fixes some types in the commit messages and spells
> Eric correctly. My apologies for getting it wrong.
>
> Jes Sorensen (2):
> strtosz() use unsigned char as isspace() is not defined for signed
> char
> strtosz() use toupper() to simplify switch statement
>
> cutils.c | 10 +++-------
> 1 files changed, 3 insertions(+), 7 deletions(-)
>
And the modf() usage? Or using STRTOSZ_DEFSUFFIX_* in the switch? Or
avoiding the extra variable in 13/18? Thanks,
Alex