[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-devel] Re: [PATCH 8/8] x86_64 config: fix compile for CONFIG_FDC=n
From: |
David Ahern |
Subject: |
[Qemu-devel] Re: [PATCH 8/8] x86_64 config: fix compile for CONFIG_FDC=n |
Date: |
Thu, 13 Jan 2011 10:25:28 -0700 |
User-agent: |
Mozilla/5.0 (X11; U; Linux x86_64; en-US; rv:1.9.2.13) Gecko/20101209 Fedora/3.1.7-0.35.b3pre.fc13 Lightning/1.0b3pre Thunderbird/3.1.7 |
On 01/13/11 10:04, Paolo Bonzini wrote:
> On 01/13/2011 07:34 AM, David Ahern wrote:
>>
>> +#ifdef CONFIG_FDC
>> /* floppy type */
>>
>> fd0 = fdctrl_get_drive_type(floppy_controller, 0);
>> @@ -403,6 +408,7 @@ void pc_cmos_init(ram_addr_t ram_size, ram_addr_t
>> above_4g_mem_size,
>> val |= 0x02; /* FPU is there */
>> val |= 0x04; /* PS/2 mouse installed */
>> rtc_set_memory(s, REG_EQUIPMENT_BYTE, val);
>> +#endif
>
> Isn't it a bit too eager? The equipment byte should still be set, or
> have you checked with a real machine?
>
> Paolo
A bit to eager. I'll fix.
David
- [Qemu-devel] [PATCH 2/8] x86_64 config: fix compile for CONFIG_VMWARE_VGA=n, (continued)
[Qemu-devel] [PATCH 8/8] x86_64 config: fix compile for CONFIG_FDC=n, David Ahern, 2011/01/13
[Qemu-devel] [PATCH 7/8] x86_64 config: fix compile for CONFIG_IDE_ISA=n, David Ahern, 2011/01/13
[Qemu-devel] [PATCH 4/8] remove unused parallel_* variables from pc.c, David Ahern, 2011/01/13
[Qemu-devel] [PATCH 1/8] fix 'no such file' error from make_device_config.sh, David Ahern, 2011/01/13
Re: [Qemu-devel] [PATCH 1/8] fix 'no such file' error from make_device_config.sh, Stefan Weil, 2011/01/14
Re: [Qemu-devel] [PATCH 0/8] misc cleanups for x86_64 disabling config settings, Isaku Yamahata, 2011/01/13