[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] Re: [PATCH] slirp/tftp.c: fix mode field
From: |
Stefan Hajnoczi |
Subject: |
Re: [Qemu-devel] Re: [PATCH] slirp/tftp.c: fix mode field |
Date: |
Wed, 12 Jan 2011 09:56:48 +0000 |
On Wed, Jan 12, 2011 at 7:22 AM, Sergei Gavrikov
<address@hidden> wrote:
> diff --git a/slirp/tftp.c b/slirp/tftp.c
> index 55e4692..a455ad1 100644
> --- a/slirp/tftp.c
> +++ b/slirp/tftp.c
> @@ -311,7 +311,7 @@ static void tftp_handle_rrq(Slirp *slirp, struct tftp_t
> *tp, int pktlen)
> return;
> }
>
> - if (memcmp(&tp->x.tp_buf[k], "octet\0", 6) != 0) {
> + if (strcasecmp((const char *)&tp->x.tp_buf[k], "octet") != 0) {
> tftp_send_error(spt, 4, "Unsupported transfer mode", tp);
> return;
> }
According to RFC 2349 the "tsize" option is also case-insensitive.
Want to include a fix for that in this patch?
Stefan
- [Qemu-devel] [PATCH] slirp/tftp.c: fix mode field, Sergei Gavrikov, 2011/01/10
- [Qemu-devel] Re: [PATCH] slirp/tftp.c: fix mode field, Sergei Gavrikov, 2011/01/12
- Re: [Qemu-devel] Re: [PATCH] slirp/tftp.c: fix mode field,
Stefan Hajnoczi <=
- Re: [Qemu-devel] Re: [PATCH] slirp/tftp.c: fix mode field, Sergei Gavrikov, 2011/01/12
- Re: [Qemu-devel] Re: [PATCH] slirp/tftp.c: fix mode field, Stefan Hajnoczi, 2011/01/12
- Re: [Qemu-devel] Re: [PATCH] slirp/tftp.c: fix mode field, Sergei Gavrikov, 2011/01/12
- [Qemu-devel] [PATCHv1] slirp: Use strcasecmp() to check tftp mode, tsize, Sergei Gavrikov, 2011/01/12
- Re: [Qemu-devel] [PATCHv1] slirp: Use strcasecmp() to check tftp mode, tsize, Edgar E. Iglesias, 2011/01/13