|
From: | Chris Krumme |
Subject: | Re: [Qemu-devel] [PATCH 1/4] qdev: Add a description field for qdev properties for documentation |
Date: | Mon, 10 Jan 2011 18:01:58 -0600 |
User-agent: | Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.9.2.13) Gecko/20101208 Lightning/1.0b2 Thunderbird/3.1.7 |
On 01/10/2011 08:31 AM, Markus Armbruster wrote:
Amit Shah<address@hidden> writes: [...]diff --git a/hw/qdev.c b/hw/qdev.c index 6fc9b02..168d0f6 100644 --- a/hw/qdev.c +++ b/hw/qdev.c @@ -185,7 +185,8 @@ int qdev_device_help(QemuOpts *opts) if (!prop->info->parse) { continue; /* no way to set it, don't show */ } - error_printf("%s.%s=%s\n", info->name, prop->name, prop->info->name); + error_printf("%s.%s=%s, %s\n", info->name, prop->name, + prop->info->name, prop->desc ?: "");
Hello Amit, Do we want to add the GCCism here of ?:? Thanks Chris
} return 1; }Output could be made prettier (align the help texts). Preferrably in a follow-up commit, because this one's seen enough respins already. [...]
[Prev in Thread] | Current Thread | [Next in Thread] |