[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-devel] Re: [PATCH 3/3] target-ppc: fix sNaN propagation
From: |
Aurelien Jarno |
Subject: |
[Qemu-devel] Re: [PATCH 3/3] target-ppc: fix sNaN propagation |
Date: |
Mon, 10 Jan 2011 20:26:20 +0100 |
User-agent: |
Mutt/1.5.18 (2008-05-17) |
On Wed, Jan 05, 2011 at 06:20:07PM +0100, Alexander Graf wrote:
>
> On 02.01.2011, at 15:39, Aurelien Jarno wrote:
>
> > The current FPU code returns 0.0 if one of the operand is a
> > signaling NaN and the VXSNAN exception is disabled.
> >
> > fload_invalid_op_excp() doesn't return a qNaN in case of a VXSNAN
> > exception as the operand should be propagated instead of a new
> > qNaN to be generated. Fix that by calling fload_invalid_op_excp()
> > only for the exception generation (if enabled), and use the softfloat
> > code to correctly compute the result.
>
> Reading through this I'm afraid I understand too little of the matter. Anyone
> else who's more proficient in FP feels like taking up the review?
>
Anybody to review this code? Nathan maybe?
--
Aurelien Jarno GPG: 1024D/F1BCDB73
address@hidden http://www.aurel32.net