Re: [Qemu-devel] [PATCH 2/6] spice: client migration.

[Gerd Hoffmann]

On 01/10/11 16:57, Alon Levy wrote:
> > > +spice_migrate_info
> > > +------------------
> > > +
> > > +Set the spice connection info for the migration target.  The spice
> > > +server will ask the spice client to automatically reconnect using the
> > > +new parameters (if specified) once the vm migration finished
> > > +successfully.
> > > +
> > > +Arguments:
> > > +
> > > +- "hostname":     migration target hostname (json-string)
> > > +- "port":         spice tcp port for plaintext channels (json-int, optional)
> > > +- "tls-port":     spice tcp port for tls-secured channels (json-int, optional)
> > > +- "cert-subject": server certificate subject (json-string, optional)
> > > +
> > > +Example:
> > > +
> > > +->  { "execute": "spice_migrate_info",
> > > +     "arguments": { "hostname": "virt42.lab.kraxel.org", "port": 1234 } }
> > > +<- { "return": {} }
> >
> > I'm wondering whether we should make this command more
> > generic, because I could likely write up a VNC extension
> > that provides the same functionality that SPICE has here.
> > so, 'graphics_migrate_info @var{spice|vnc|...} ...other vars..'
>
> Considering it isn't actually just graphics how about client_migrate_info?

I like client_migrate_info and it fits both spice+vnc naming too.

Given that vnc just needs hostname and port (which are present already) 
and the arguments not used by vnc are optional all we need to do is 
rename the command and add a "protocol" argument similar to 
"set_password", correct?

cheers,
  Gerd