[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-devel] Re: [PATCH 2/2] checkpatch: adjust to QEMUisms
From: |
Jan Kiszka |
Subject: |
[Qemu-devel] Re: [PATCH 2/2] checkpatch: adjust to QEMUisms |
Date: |
Sun, 09 Jan 2011 16:54:15 +0100 |
User-agent: |
Mozilla/5.0 (X11; U; Linux i686 (x86_64); de; rv:1.8.1.12) Gecko/20080226 SUSE/2.0.0.12-1.1 Thunderbird/2.0.0.12 Mnenhy/0.7.5.666 |
Am 09.01.2011 14:24, Blue Swirl wrote:
> On Sun, Jan 9, 2011 at 1:01 PM, Stuart Brady <address@hidden> wrote:
>> On Sun, Jan 09, 2011 at 11:46:33AM +0000, Blue Swirl wrote:
>>> Change checkpatch.pl for QEMU use:
>>> - Root directory detection
>>> - Forbid tabs
>>> - Indent at 4 spaces
>>> - Allow typedefs
>>> - Enforce brace use even for single statement blocks
>>> - Don't suggest nonexistent cleanup tools
>
> BTW, I checked the last 99 commits with the script. The only real
> problems I saw were that the script complains that CPP #if statements
> are missing braces and the tabs check fires also for old code.
I bet that's fixable with a few additional checks. :)
>
> for i in '' 1 2 3 4 5 6 7 8 9; do for j in 0 1 2 3 4 5 6 7 8 9; do
> echo $i$j; git show HEAD~$i$j >a; clear;cat a; perl
> checkpatch.pl-0.31+QEMU --root=. a; read foo; done; done
>
>> Could you separate out the coding style changes, please?
>>
>> Otherwise, it's just 2900 lines added and 2900 lines removed.
>
> Does git-am understand patches in -M style? Is there a config option?
Would be surprising if not.
>
> Here's the patch with rename detection on for easier commenting:
Line-wrapped unfortunately.
> diff --git a/checkpatch.pl-0.31 b/checkpatch.pl-0.31+QEMU
> similarity index 97%
> rename from checkpatch.pl-0.31
> rename to checkpatch.pl-0.31+QEMU
I prefer to track the origin in git, not in the file name. For
convenience, we need executable(!) checkpath.pl, at least a symbolic
link to it.
Otherwise, kudos for picking this up!
Jan
signature.asc
Description: OpenPGP digital signature