[Qemu-devel] Re: [PATCH V2] savevm: use error_report for vmstate_save error

[Alex Williamson]

On Fri, 2011-01-07 at 17:27 +0100, Jan Kiszka wrote:
> Am 07.01.2011 17:10, Alex Williamson wrote:
> > On Fri, 2011-01-07 at 17:03 +0100, Jan Kiszka wrote:
> >> Am 07.01.2011 16:58, Alex Williamson wrote:
> >>> If migration is done in the background with the -d option, mon is
> >>> NULL and this error message is lost.  Instead use error_report().
> >>>
> >>> Signed-off-by: Alex Williamson <address@hidden>
> >>
> >> Reviewed-by: Jan Kiszka <address@hidden>
> >>
> >> As already at it: Is this the only error during migration that can get
> >> lost this way?
> > 
> > On the migration source side, I think so.  All the save callbacks are
> > return void, so device saves aren't allow to fail.  The unmigratable
> > device registration is the only way I know to trigger an error on this
> > end.  Thanks,
> 
> Hmm, thinking about this again, wouldn't it be a better user experience
> to check this in advance, at a time where the issuing console is still
> listening?

I hope v3 addresses this as you were hoping.  It also fixes a couple
other issues with no_migrate.  Thanks,

Alex