[Qemu-devel] Re: [PATCH v3 12/21] kvm: x86: Drop MCE MSRs write back restrictions

[Jan Kiszka]

Am 05.01.2011 07:42, Huang Ying wrote:
> On Tue, 2011-01-04 at 16:32 +0800, Jan Kiszka wrote:
>> From: Jan Kiszka <address@hidden>
>>
>> There is no need to restrict writing back MCE MSRs to reset or full
>> state updates as setting their values has no side effects.
> 
> Sorry for late.

Don't worry.

> 
> The MCE MSRs contents is sticky for warm reset except MCG_STATUS, so
> their content should be kept.  And the following sequence may set
> uncorrected value in MCE registers.
> 
> savevm -> loadvm -> (OS clear MCE registers) -> reset -> (MCE registers
> has new (uncorrected) value)

Sorry, I can't follow. Unless I miss some subtle detail, the question is
not when we transfer the mcg_* CPUState fields to the kernel, but when
and how we manipulate them in user space, e.g. on reset. Where are those
fields touched incorrectly between get and put msrs so that we cannot
write them back?

Jan

signature.asc
Description: OpenPGP digital signature