Re: [Qemu-devel] [PATCH v2 0/6] [RFC] New SPARC machine: Leon3

[Andreas Färber]

Hi Fabien,

Am 03.01.2011 um 15:06 schrieb Fabien Chouteau:

> New version of the Leon3 emulation. Many modifications since v1,  
> mostly to
> follow the Qemu architecture and to implement features in a more  
> generic way.
>
> Again, please feel free to comment.

Informally, if you look through the commits, we roughly follow the  
GNOME guidelines [1]:

* The subject line does not end with a dot.
* All six patches could be prefixed with a "sparc" tag as  
categorization for people who don't know Leon3 or GRLIB.
* Usually an empty commit body indicates that some explanation is  
missing. (guilty there myself, I admit...)
* I'd put the "as described in ..." info into a sentence in the body  
of the commit message to shorten the subject.

You might want to split up patch 4 to go alongside 1-3, so that  
GPTimer is accompanied by the link to the GRLIB docs.

Regards,
Andreas

[1] http://live.gnome.org/Git/CommitMessages