[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-devel] Re: [PATCH v3 15/21] kvm: x86: Introduce kvmclock device to
|
From: |
Glauber Costa |
|
Subject: |
[Qemu-devel] Re: [PATCH v3 15/21] kvm: x86: Introduce kvmclock device to save/restore its state |
|
Date: |
Tue, 04 Jan 2011 09:43:07 -0200 |
On Tue, 2011-01-04 at 12:34 +0100, Jan Kiszka wrote:
> Am 04.01.2011 12:08, Glauber Costa wrote:
> > On Tue, 2011-01-04 at 09:32 +0100, Jan Kiszka wrote:
> >> From: Jan Kiszka <address@hidden>
> >>
> >> If kvmclock is used, which implies the kernel supports it, register a
> >> kvmclock device with the sysbus. Its main purpose is to save and restore
> >> the kernel state on migration, but this will also allow to visualize it
> >> one day.
> >
> > I would prefer having no pre-save, and doing the ioctl in the state
> > change handler. But I won't nitpick about that, if the maintainers think
> > this is okay, all the rest of the patch looks fine as well.
>
> I did this for a reason: to be able to obtain the current clock state
> even while the vm is running. It's cleaner IMHO.
but if we're on pre-save, we are certain that the vm is stopped at this
moment, no ?
- [Qemu-devel] Re: [PATCH v3 12/21] kvm: x86: Drop MCE MSRs write back restrictions, (continued)
[Qemu-devel] [PATCH v3 14/21] kvm: x86: Fix !CONFIG_KVM_PARA build, Jan Kiszka, 2011/01/04
[Qemu-devel] [PATCH v3 16/21] kvm: Drop smp_cpus argument from init functions, Jan Kiszka, 2011/01/04
[Qemu-devel] [PATCH v3 19/21] kvm: Flush coalesced mmio buffer on IO window exits, Jan Kiszka, 2011/01/04
[Qemu-devel] [PATCH v3 18/21] kvm: x86: Rework identity map and TSS setup for larger BIOS sizes, Jan Kiszka, 2011/01/04
[Qemu-devel] [PATCH v3 20/21] kvm: Do not use qemu_fair_mutex, Jan Kiszka, 2011/01/04
[Qemu-devel] [PATCH v3 15/21] kvm: x86: Introduce kvmclock device to save/restore its state, Jan Kiszka, 2011/01/04
[Qemu-devel] [PATCH v3 21/21] kvm: x86: Implicitly clear nmi_injected/pending on reset, Jan Kiszka, 2011/01/04
[Qemu-devel] [PATCH v3 13/21] kvm: Eliminate KVMState arguments, Jan Kiszka, 2011/01/04
[Qemu-devel] [PATCH v3 17/21] kvm: Consolidate must-have capability checks, Jan Kiszka, 2011/01/04
[Qemu-devel] [PATCH 11.5/21] Synchronize VCPU states before reset, Jan Kiszka, 2011/01/05
[Qemu-devel] [PATCH 22/21] kvm: x86: Only read/write MSR_KVM_ASYNC_PF_EN if supported, Jan Kiszka, 2011/01/05
[Qemu-devel] Re: [PATCH v3 00/21] [uq/master] Prepare for more qemu-kvm merging, Marcelo Tosatti, 2011/01/05