[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-devel] Re: qemu vs. kvm: When to flush the coalesced mmio buffer?
|
From: |
Jan Kiszka |
|
Subject: |
[Qemu-devel] Re: qemu vs. kvm: When to flush the coalesced mmio buffer? |
|
Date: |
Mon, 03 Jan 2011 13:34:12 +0100 |
|
User-agent: |
Mozilla/5.0 (X11; U; Linux i686 (x86_64); de; rv:1.8.1.12) Gecko/20080226 SUSE/2.0.0.12-1.1 Thunderbird/2.0.0.12 Mnenhy/0.7.5.666 |
Am 03.01.2011 13:32, Avi Kivity wrote:
> On 01/03/2011 02:11 PM, Jan Kiszka wrote:
>> Hi again,
>>
>> another subtle difference between qemu-kvm and upstream:
>>
>> When we leave the guest for an IO window (KVM_RUN returns EINTR or
>> EAGAIN), we call kvm_flush_coalesced_mmio_buffer in qemu-kvm but not in
>> upstream. When version is better? I can't find any rationales in both
>> git logs.
>
> We must flush on EINTR, otherwise a live migration can leave some mmios
> in the source host and not replay them on the destination host.
>
> (plus, as Gleb says, if you're in userspace you might as well flush)
>
OK, will append a fix to my series.
Thanks,
Jan
signature.asc
Description: OpenPGP digital signature