[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH V4 3/3] qmp, nmi: convert do_inject_nmi() to QOb
|
From: |
Markus Armbruster |
|
Subject: |
Re: [Qemu-devel] [PATCH V4 3/3] qmp, nmi: convert do_inject_nmi() to QObject, QError |
|
Date: |
Mon, 20 Dec 2010 18:01:34 +0100 |
|
User-agent: |
Gnus/5.13 (Gnus v5.13) Emacs/23.1 (gnu/linux) |
Lai Jiangshan <address@hidden> writes:
> Make we can inject NMI via qemu-monitor-protocol.
> We use "inject-nmi" for the qmp command name, the meaning is clearer.
> When cpu-index is found invalid in runtime, it will report
> QERR_INVALID_PARAMETER_VALUE.
This patch does two separate things:
1. Fix do_inject_nmi() to detect invalid arguments.
2. Convert it to QObject.
If you have to respin anyway, please split the patch to keep the two
separate.