qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH v3 1/7] apic: Don't use SoftFloat uint32 type


From: Blue Swirl
Subject: Re: [Qemu-devel] [PATCH v3 1/7] apic: Don't use SoftFloat uint32 type
Date: Sun, 19 Dec 2010 11:20:55 +0000

On Sat, Dec 18, 2010 at 4:25 PM, Andreas Färber <address@hidden> wrote:
> softfloat.h's uint32 type has least-width semantics,
> whereas surrounding code uses uint32_t, so use uint32_t too.

I think patches 1 to 3 don't have much to do with softfloat, the type
uses are just general sloppiness to use non-standard types instead of
deliberate softfloat type use. So if there is a respin for some
reason, please split off those from the softfloat patches and adjust
the descriptions. Otherwise, if the patches are going to be applied,
splitting is not necessary.



reply via email to

[Prev in Thread] Current Thread [Next in Thread]