[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-devel] [PATCH 15/30] usb: create USBPortOps, move attach there.
From: |
Gerd Hoffmann |
Subject: |
[Qemu-devel] [PATCH 15/30] usb: create USBPortOps, move attach there. |
Date: |
Fri, 17 Dec 2010 12:26:31 +0100 |
Create USBPortOps struct, move the attach function to that struct.
Signed-off-by: Gerd Hoffmann <address@hidden>
---
hw/usb-bus.c | 4 ++--
hw/usb-hub.c | 6 +++++-
hw/usb-musb.c | 6 +++++-
hw/usb-ohci.c | 6 +++++-
hw/usb-uhci.c | 6 +++++-
hw/usb.c | 2 +-
hw/usb.h | 8 +++++---
7 files changed, 28 insertions(+), 10 deletions(-)
diff --git a/hw/usb-bus.c b/hw/usb-bus.c
index 15a42ff..f534bc3 100644
--- a/hw/usb-bus.c
+++ b/hw/usb-bus.c
@@ -111,11 +111,11 @@ USBDevice *usb_create_simple(USBBus *bus, const char
*name)
}
void usb_register_port(USBBus *bus, USBPort *port, void *opaque, int index,
- usb_attachfn attach)
+ USBPortOps *ops)
{
port->opaque = opaque;
port->index = index;
- port->attach = attach;
+ port->ops = ops;
QTAILQ_INSERT_TAIL(&bus->free, port, next);
bus->nfree++;
}
diff --git a/hw/usb-hub.c b/hw/usb-hub.c
index 5a7bc44..1de2e0f 100644
--- a/hw/usb-hub.c
+++ b/hw/usb-hub.c
@@ -506,6 +506,10 @@ static void usb_hub_handle_destroy(USBDevice *dev)
}
}
+static USBPortOps usb_hub_port_ops = {
+ .attach = usb_hub_attach,
+};
+
static int usb_hub_initfn(USBDevice *dev)
{
USBHubState *s = DO_UPCAST(USBHubState, dev, dev);
@@ -516,7 +520,7 @@ static int usb_hub_initfn(USBDevice *dev)
for (i = 0; i < NUM_PORTS; i++) {
port = &s->ports[i];
usb_register_port(usb_bus_from_device(dev),
- &port->port, s, i, usb_hub_attach);
+ &port->port, s, i, &usb_hub_port_ops);
port->wPortStatus = PORT_STAT_POWER;
port->wPortChange = 0;
}
diff --git a/hw/usb-musb.c b/hw/usb-musb.c
index 7f15842..916aa06 100644
--- a/hw/usb-musb.c
+++ b/hw/usb-musb.c
@@ -261,6 +261,10 @@
static void musb_attach(USBPort *port, USBDevice *dev);
+static USBPortOps musb_port_ops = {
+ .attach = musb_attach,
+};
+
typedef struct {
uint16_t faddr[2];
uint8_t haddr[2];
@@ -343,7 +347,7 @@ struct MUSBState {
}
usb_bus_new(&s->bus, NULL /* FIXME */);
- usb_register_port(&s->bus, &s->port, s, 0, musb_attach);
+ usb_register_port(&s->bus, &s->port, s, 0, &musb_port_ops);
return s;
}
diff --git a/hw/usb-ohci.c b/hw/usb-ohci.c
index 8fb2f83..3f71291 100644
--- a/hw/usb-ohci.c
+++ b/hw/usb-ohci.c
@@ -1676,6 +1676,10 @@ static CPUWriteMemoryFunc * const ohci_writefn[3]={
ohci_mem_write
};
+static USBPortOps ohci_port_ops = {
+ .attach = ohci_attach,
+};
+
static void usb_ohci_init(OHCIState *ohci, DeviceState *dev,
int num_ports, uint32_t localmem_base)
{
@@ -1705,7 +1709,7 @@ static void usb_ohci_init(OHCIState *ohci, DeviceState
*dev,
usb_bus_new(&ohci->bus, dev);
ohci->num_ports = num_ports;
for (i = 0; i < num_ports; i++) {
- usb_register_port(&ohci->bus, &ohci->rhport[i].port, ohci, i,
ohci_attach);
+ usb_register_port(&ohci->bus, &ohci->rhport[i].port, ohci, i,
&ohci_port_ops);
}
ohci->async_td = 0;
diff --git a/hw/usb-uhci.c b/hw/usb-uhci.c
index 1d83400..1427c2f 100644
--- a/hw/usb-uhci.c
+++ b/hw/usb-uhci.c
@@ -1101,6 +1101,10 @@ static void uhci_map(PCIDevice *pci_dev, int region_num,
register_ioport_read(addr, 32, 1, uhci_ioport_readb, s);
}
+static USBPortOps uhci_port_ops = {
+ .attach = uhci_attach,
+};
+
static int usb_uhci_common_initfn(UHCIState *s)
{
uint8_t *pci_conf = s->dev.config;
@@ -1115,7 +1119,7 @@ static int usb_uhci_common_initfn(UHCIState *s)
usb_bus_new(&s->bus, &s->dev.qdev);
for(i = 0; i < NB_PORTS; i++) {
- usb_register_port(&s->bus, &s->ports[i].port, s, i, uhci_attach);
+ usb_register_port(&s->bus, &s->ports[i].port, s, i, &uhci_port_ops);
}
s->frame_timer = qemu_new_timer(vm_clock, uhci_frame_timer, s);
s->expire_time = qemu_get_clock(vm_clock) +
diff --git a/hw/usb.c b/hw/usb.c
index a326bcf..39d29f3 100644
--- a/hw/usb.c
+++ b/hw/usb.c
@@ -28,7 +28,7 @@
void usb_attach(USBPort *port, USBDevice *dev)
{
- port->attach(port, dev);
+ port->ops->attach(port, dev);
}
/**********************/
diff --git a/hw/usb.h b/hw/usb.h
index b8f13cc..e98808a 100644
--- a/hw/usb.h
+++ b/hw/usb.h
@@ -216,12 +216,14 @@ struct USBDeviceInfo {
USBDevice *(*usbdevice_init)(const char *params);
};
-typedef void (*usb_attachfn)(USBPort *port, USBDevice *dev);
+typedef struct USBPortOps {
+ void (*attach)(USBPort *port, USBDevice *dev);
+} USBPortOps;
/* USB port on which a device can be connected */
struct USBPort {
USBDevice *dev;
- usb_attachfn attach;
+ USBPortOps *ops;
void *opaque;
int index; /* internal port index, may be used with the opaque */
QTAILQ_ENTRY(USBPort) next;
@@ -332,7 +334,7 @@ USBDevice *usb_create(USBBus *bus, const char *name);
USBDevice *usb_create_simple(USBBus *bus, const char *name);
USBDevice *usbdevice_create(const char *cmdline);
void usb_register_port(USBBus *bus, USBPort *port, void *opaque, int index,
- usb_attachfn attach);
+ USBPortOps *ops);
void usb_unregister_port(USBBus *bus, USBPort *port);
int usb_device_attach(USBDevice *dev);
int usb_device_detach(USBDevice *dev);
--
1.7.1
- [Qemu-devel] [PATCH 06/30] usb wacom: use new descriptor infrastructure., (continued)
- [Qemu-devel] [PATCH 06/30] usb wacom: use new descriptor infrastructure., Gerd Hoffmann, 2010/12/17
- [Qemu-devel] [PATCH 09/30] usb descriptors: add settable strings., Gerd Hoffmann, 2010/12/17
- [Qemu-devel] [PATCH 05/30] usb storage: use new descriptor infrastructure., Gerd Hoffmann, 2010/12/17
- [Qemu-devel] [PATCH 08/30] usb hub: use new descriptor infrastructure., Gerd Hoffmann, 2010/12/17
- [Qemu-devel] [PATCH 12/30] usb: move USB_REQ_SET_ADDRESS handling to common code, Gerd Hoffmann, 2010/12/17
- [Qemu-devel] [PATCH 07/30] usb bluetooth: use new descriptor infrastructure., Gerd Hoffmann, 2010/12/17
- [Qemu-devel] [PATCH 17/30] usb: add usb_wakeup() + wakeup callback to port ops, Gerd Hoffmann, 2010/12/17
- [Qemu-devel] [PATCH 14/30] usb: move remote wakeup handling to common code, Gerd Hoffmann, 2010/12/17
- [Qemu-devel] [PATCH 13/30] usb: move USB_REQ_{GET, SET}_CONFIGURATION handling to common code, Gerd Hoffmann, 2010/12/17
- [Qemu-devel] [PATCH 19/30] usb: hub: remote wakeup support., Gerd Hoffmann, 2010/12/17
- [Qemu-devel] [PATCH 15/30] usb: create USBPortOps, move attach there.,
Gerd Hoffmann <=
- [Qemu-devel] [PATCH 11/30] usb network: use new descriptor infrastructure., Gerd Hoffmann, 2010/12/17
- [Qemu-devel] [PATCH 20/30] usb: hid: remote wakeup support., Gerd Hoffmann, 2010/12/17
- [Qemu-devel] [PATCH 21/30] usb: hid: change serial number to "42"., Gerd Hoffmann, 2010/12/17
- [Qemu-devel] [PATCH 27/30] usb storage: fix status reporting, Gerd Hoffmann, 2010/12/17
- [Qemu-devel] [PATCH 28/30] usb storage: handle long responses, Gerd Hoffmann, 2010/12/17
- [Qemu-devel] [PATCH 24/30] usb: add usb_desc_attach, Gerd Hoffmann, 2010/12/17
- [Qemu-devel] [PATCH 16/30] usb: rework attach/detach workflow, Gerd Hoffmann, 2010/12/17
- [Qemu-devel] [PATCH 22/30] usb: add speed mask to ports, Gerd Hoffmann, 2010/12/17
- [Qemu-devel] [PATCH 26/30] usb storage: high speed support, Gerd Hoffmann, 2010/12/17
- [Qemu-devel] [PATCH 23/30] usb: add attach callback, Gerd Hoffmann, 2010/12/17