[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-devel] Re: [PATCH] ide: Register vm change state handler once only
From: |
Kevin Wolf |
Subject: |
[Qemu-devel] Re: [PATCH] ide: Register vm change state handler once only |
Date: |
Thu, 16 Dec 2010 13:29:04 +0100 |
User-agent: |
Mozilla/5.0 (X11; U; Linux x86_64; en-US; rv:1.9.1.15) Gecko/20101027 Fedora/3.0.10-1.fc12 Thunderbird/3.0.10 |
Am 10.12.2010 15:47, schrieb Stefan Hajnoczi:
> We register the vm change state handler in a PCI BAR map() function.
> This function can be called multiple times throughout the lifetime of a
> PCI IDE device. This results in duplicate vm change state handlers
> being register, none of which are ever unregistered.
>
> Instead, register the vm change state handler in the device's init
> function once and for all.
>
> piix tested, cmd646 and via not tested.
>
> Signed-off-by: Stefan Hajnoczi <address@hidden>
This conflicts with the AHCI patches. Can you rebase on top of the block
branch?
Kevin