[Qemu-devel] Re: [PATCH] migration: ide: drop ide_pci_post_load()

[Juan Quintela]

Jason Wang <address@hidden> wrote:
> When the bmdma transfering ended, the unit were set to -1(0xFF), but
> after migration ide_pci_post_load() would change it to 1. This is not
> intended and it also would break the migration stability that we
> could not get exactly the same exec file before and after migration.
>
> So this patch drop the ide_pci_post_load() and it would also make
> possible to debugging of migration through comparing the exec files.
>
> Signed-off-by: Jason Wang <address@hidden>
>
> I'm not sure whether this is the best way to handle this issue. Should
> we still care about the migration from old guest?

Basically we have unit=-1 when there is an error/we ended an operation.
Stable image migration are having trouble with it, and we only generate
0/1/-1 nowadays.

Acked-by: Juan Quintela <address@hidden>