[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-devel] Re: [PATCH 1/1] qemu-img: Deprecate obsolete -6 and -e opti
From: |
Jes Sorensen |
Subject: |
[Qemu-devel] Re: [PATCH 1/1] qemu-img: Deprecate obsolete -6 and -e options |
Date: |
Tue, 07 Dec 2010 17:17:58 +0100 |
User-agent: |
Mozilla/5.0 (X11; U; Linux x86_64; en-US; rv:1.9.2.12) Gecko/20101103 Fedora/1.0-0.33.b2pre.fc14 Lightning/1.0b3pre Thunderbird/3.1.6 |
On 12/07/10 17:02, Kevin Wolf wrote:
>> @@ -323,11 +310,13 @@ static int img_create(int argc, char **argv)
>> fmt = optarg;
>> break;
>> case 'e':
>> - flags |= BLOCK_FLAG_ENCRYPT;
>> - break;
>> + printf("qemu-img: option -e is deprecated, please use \'-o "
>> + "encryption\' instead!\n");
>> + return -1;
>
> The return value of this function is used as exit code of qemu-img, so 1
> is probably better than -1.
>
> Also, is there a reason why you use printf and not error (which writes
> the message to stderr)?
I looked for fprintf(stderr.... and found nothing so I used printf()
instead. I'm happy to change it to use error() and the return value too.
Thanks for the feedback.
Cheers,
Jes