[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 08/12] ARM: Return correct result for single<->d
From: |
Nathan Froyd |
Subject: |
Re: [Qemu-devel] [PATCH 08/12] ARM: Return correct result for single<->double conversion of NaN |
Date: |
Mon, 29 Nov 2010 12:21:05 -0800 |
User-agent: |
Mutt/1.5.17+20080114 (2008-01-14) |
On Mon, Nov 29, 2010 at 08:04:42PM +0000, Peter Maydell wrote:
> On 29 November 2010 19:54, Nathan Froyd <address@hidden> wrote:
> > On Mon, Nov 29, 2010 at 07:25:18PM +0000, Peter Maydell wrote:
> >> (b) add to and extend the softfloat API whenever you have some
> >> floating-point related thing it doesn't currently support
> >
> > I think this is the best approach whenever possible.
>
> OK. Do we care about maintaining consistency of the API between
> softfloat and softfloat-native (the latter used only on x86, x86_64,
> cris, sh4, sh4eb)?
softfloat-native should just go away. I would not worry about API
compatibility between native and non-native configurations there.
> >> (c) do something suboptimal where the softfloat API provides
> >> some-API-but-not-quite-the-ideal-API (which I'm not particularly
> >> keen on and is what I see the "is_nan() || is_signalling_nan()"
> >> approach as)
> >
> > Yes, this is ugly. Are you up for running:
> >
> > perl -p -i -e 's/float(\d+)_is_nan/float\1_is_quiet_nan/g' target-*/*.c
> >
> > (and also carefully in fpu/*) or similar and moving the bit-twiddling
> > float_is_nan into fpu/?
>
> I'm happy to produce a patch doing that if it will be committed :-)
Well, I can't promise the committal part... :)
-Nathan
- Re: [Qemu-devel] [PATCH 09/12] ARM: Ignore top 16 bits when doing VCVT from 16 bit fixed point, (continued)
[Qemu-devel] [PATCH 01/12] target-arm: Add support for PKHxx in thumb2, Peter Maydell, 2010/11/23
[Qemu-devel] [PATCH 07/12] ARM: Return correct result for float-to-integer conversion of NaN, Peter Maydell, 2010/11/23
[Qemu-devel] [PATCH 03/12] target-arm: Handle 'smc' as an undefined instruction, Peter Maydell, 2010/11/23