Re: [Qemu-devel] [Patch] Small fix for qemu APIC for Mac OS X support

[Alexander Graf]

On 23.11.2010, at 22:25, adq wrote:

> This patch ups the APIC version from 0x11 to 0x14. After that Mac OS X
> loads successfully (with appropriate kexts, applesmc ain't hooked up
> properly yet I see unfortunately).

AppleSMC emulation is upstream, but the ACPI entries are missing. Once you add 
those, all is fine.

> According to to the Intel IA-32 Software Developers Manual Vol 3 page
> 290, the version should be 0x14 Pentium 4/Xeon CPUs anyway.
> 
> Signed-off-by: Andrew de Quincey <address@hidden>
> 
> diff --git a/hw/apic.c b/hw/apic.c
> index 5f4a87c..20304e0 100644
> --- a/hw/apic.c
> +++ b/hw/apic.c
> @@ -704,7 +704,7 @@ static uint32_t apic_mem_readl(void *opaque,
> target_phys_addr_t addr)
>         val = s->id << 24;
>         break;
>     case 0x03: /* version */
> -        val = 0x11 | ((APIC_LVT_NB - 1) << 16); /* version 0x11 */
> +        val = 0x14 | ((APIC_LVT_NB - 1) << 16); /* version 0x14 */

What exactly changed between the versions? Did new registers get introduced or 
subtle behavior change? Is there some proper documentation on the changed 
between the apic versions?


Alex