|
From: | Jes Sorensen |
Subject: | Re: [Qemu-devel] [PATCH 1/1] NBD isn't used by qemu-img, so don't link qemu-img against NBD objects |
Date: | Sun, 21 Nov 2010 13:31:24 +0100 |
User-agent: | Mozilla/5.0 (X11; U; Linux x86_64; en-US; rv:1.9.2.12) Gecko/20101103 Fedora/1.0-0.33.b2pre.fc14 Lightning/1.0b3pre Thunderbird/3.1.6 |
On 11/20/10 18:22, Andreas Färber wrote: > Am 19.11.2010 um 17:30 schrieb address@hidden: > >> From: Jes Sorensen <address@hidden> >> >> Signed-off-by: Jes Sorensen <address@hidden> >> --- >> Makefile | 2 +- >> Makefile.objs | 12 ++++++++++-- >> 2 files changed, 11 insertions(+), 3 deletions(-) > > Tested-by: Andreas Färber <address@hidden> > > Looks good to me and a clean build works okay. > > Any plans for a way to disable NBD build completely? There are warnings > about use of daemon() on Mac OS X and possibly Solaris, and there's > little point in building qemu-nbd if one does not use it. I think it would be worth adding as an option, however letting it default to 'on' to make sure it gets at least build tested unless a user explicitly disables it. Cheers, Jes
[Prev in Thread] | Current Thread | [Next in Thread] |