RE: [Qemu-devel] [PATCH]target-arm: fix semihosting commandline handling

[Schildbach, Wolfgang]

Please disregard my earlier patch. Due to my not being familiar with
git, I posted a wrong version of my code. I'll follow up with a new
version later.

(My previous post seems to not have made it to the list. My apologies if
you receive this twice.)

- Wolfgang Schildbach
 
 

________________________________

From: address@hidden
[mailto:address@hidden On Behalf Of
Schildbach, Wolfgang
Sent: Friday, November 19, 2010 5:22 PM
To: address@hidden
Cc: address@hidden
Subject: [Qemu-devel] [PATCH]target-arm: fix semihosting commandline
handling


The ARM semihosting commandline handling does not work -- please see
details in bug report 673613,
https://bugs.launchpad.net/qemu/+bug/673613 .
 
The following patch, suggested by Peter Maydell, fixes the problem. I
have tested the patch on the latest development tree, on which it works
(after one unrelated fix).
 
Best regards,
- Wolfgang Schildbach
 
---
diff --git a/arm-semi.c b/arm-semi.c
index 0687b03..53b40e4 100644
--- a/arm-semi.c
+++ b/arm-semi.c
@@ -373,45 +373,48 @@ uint32_t do_arm_semihosting(CPUState *env)
 #ifdef CONFIG_USER_ONLY
         /* Build a commandline from the original argv.  */
         {
-            char **arg = ts->info->host_argv;
-            int len = ARG(1);
-            /* lock the buffer on the ARM side */
-            char *cmdline_buffer = (char*)lock_user(VERIFY_WRITE,
ARG(0), len, 0);
+            int i ;
 
-            if (!cmdline_buffer)
-                /* FIXME - should this error code be -TARGET_EFAULT ?
*/
-                return (uint32_t)-1;
+            char *arm_cmdline_buffer ;
+            const char *host_cmdline_buffer ;
 
-            s = cmdline_buffer;
-            while (*arg && len > 2) {
-                int n = strlen(*arg);
+            int arm_cmdline_len = ARG(1) ;
+            int host_cmdline_len =
ts->info->arg_end-ts->info->arg_start ;
 
-                if (s != cmdline_buffer) {
-                    *(s++) = ' ';
-                    len--;
-                }
-                if (n >= len)
-                    n = len - 1;
-                memcpy(s, *arg, n);
-                s += n;
-                len -= n;
-                arg++;
-            }
-            /* Null terminate the string.  */
-            *s = 0;
-            len = s - cmdline_buffer;
+            if (host_cmdline_len > arm_cmdline_len)
+                return (uint32_t)-1; /* command line too long */
+
+            /* lock the buffers on the ARM side */
+            arm_cmdline_buffer = (char*)lock_user(VERIFY_WRITE, ARG(0),
host_cmdline_len, 0);
+            host_cmdline_buffer = (const char*)lock_user(PAGE_READ,
ts->info->arg_start, host_cmdline_len, 0);
 
-            /* Unlock the buffer on the ARM side.  */
-            unlock_user(cmdline_buffer, ARG(0), len);
+            if (arm_cmdline_buffer && host_cmdline_buffer)
+            {
 
-            /* Adjust the commandline length argument.  */
-            SET_ARG(1, len);
+                /* the last argument is zero-terminated;
+                   no need for additional termination */ 
+                memcpy(arm_cmdline_buffer, host_cmdline_buffer,
host_cmdline_len);
 
-            /* Return success if commandline fit into buffer.  */
-            return *arg ? -1 : 0;
+                /* separate arguments by white spaces */
+                for (i = 0; i < host_cmdline_len-1; i++) {
+                    if (arm_cmdline_buffer[i] == 0) {
+                        arm_cmdline_buffer[i] = ' ';
+                    }
+                }
+
+                /* Adjust the commandline length argument.  */
+                SET_ARG(1, host_cmdline_len);
+            }
+
+            /* Unlock the buffers on the ARM side.  */
+            unlock_user(arm_cmdline_buffer, ARG(0), host_cmdline_len);
+            unlock_user((void*)host_cmdline_buffer,
ts->info->arg_start, host_cmdline_len);
+   
+            /* Return success if we could return a commandline.  */
+            return (arm_cmdline_buffer && host_cmdline_buffer) ? 0 :
-1;
         }
 #else
-      return -1;
+        return -1;
 #endif
     case SYS_HEAPINFO:
         {
diff --git a/bsd-user/bsdload.c b/bsd-user/bsdload.c
index 14a93bf..6d9bb6f 100644
--- a/bsd-user/bsdload.c
+++ b/bsd-user/bsdload.c
@@ -176,8 +176,6 @@ int loader_exec(const char * filename, char ** argv,
char ** envp,
 
     retval = prepare_binprm(&bprm);
 
-    infop->host_argv = argv;
-
     if(retval>=0) {
         if (bprm.buf[0] == 0x7f
                 && bprm.buf[1] == 'E'
diff --git a/bsd-user/qemu.h b/bsd-user/qemu.h
index 9763616..e343894 100644
--- a/bsd-user/qemu.h
+++ b/bsd-user/qemu.h
@@ -50,7 +50,6 @@ struct image_info {
     abi_ulong entry;
     abi_ulong code_offset;
     abi_ulong data_offset;
-    char      **host_argv;
     int       personality;
 };
 
diff --git a/linux-user/linuxload.c b/linux-user/linuxload.c
index 9ee27c3..ac8c486 100644
--- a/linux-user/linuxload.c
+++ b/linux-user/linuxload.c
@@ -174,8 +174,6 @@ int loader_exec(const char * filename, char ** argv,
char ** envp,
 
     retval = prepare_binprm(bprm);
 
-    infop->host_argv = argv;
-
     if(retval>=0) {
         if (bprm->buf[0] == 0x7f
                 && bprm->buf[1] == 'E'
diff --git a/linux-user/qemu.h b/linux-user/qemu.h
index 708021e..8f0a81f 100644
--- a/linux-user/qemu.h
+++ b/linux-user/qemu.h
@@ -50,7 +50,6 @@ struct image_info {
         abi_ulong       saved_auxv;
         abi_ulong       arg_start;
         abi_ulong       arg_end;
-        char            **host_argv;
  int  personality;
 };
 

 
- Wolfgang