[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 04/16] scsi: INQUIRY VPD fixes
|
From: |
Christoph Hellwig |
|
Subject: |
Re: [Qemu-devel] [PATCH 04/16] scsi: INQUIRY VPD fixes |
|
Date: |
Fri, 19 Nov 2010 19:34:01 +0100 |
|
User-agent: |
Mutt/1.3.28i |
On Thu, Nov 18, 2010 at 03:47:00PM +0100, Hannes Reinecke wrote:
>
> We should announce and support the block device characterics page
> only on block devices, not on CDROMs. And the VPD page 0x83 has
> an off-by-one error.
Looks good. This code would be a lot cleaner by splitting all vpd
emulations out into separate helpers, btw.