[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [RFC][PATCH v3 16/21] virtproxy: add option parser help
From: |
Jes Sorensen |
Subject: |
Re: [Qemu-devel] [RFC][PATCH v3 16/21] virtproxy: add option parser helper vp_parse() |
Date: |
Thu, 18 Nov 2010 12:43:33 +0100 |
User-agent: |
Mozilla/5.0 (X11; U; Linux x86_64; en-US; rv:1.9.2.12) Gecko/20101103 Fedora/1.0-0.33.b2pre.fc14 Lightning/1.0b3pre Thunderbird/3.1.6 |
On 11/16/10 02:16, Michael Roth wrote:
> +/* utility function to parse iforward/oforward options for qemu-vp
> + * or virtproxy chardev and put them into QemuOpts
> + */
> +int vp_parse(QemuOpts *opts, const char *str, bool is_channel)
> +{
> + /* TODO: use VP_SERVICE_ID_LEN, bring it into virtproxy.h */
> + char service_id[32];
> + char channel_method[32];
> + char index[10];
> + char *addr;
> + char port[33];
> + int pos, ret;
> +
> + if (is_channel == false) {
> + /* parse service id */
> + ret = sscanf(str,"%32[^:]:%n",service_id,&pos);
> + if (ret != 1) {
> + LOG("error parsing service id");
> + return -1;
-EINVAL seems more useful than -1
Cheers,
Jes
- [Qemu-devel] [RFC][PATCH v3 13/21] virtproxy: interfaces to set/remove VPIForwards, (continued)
[Qemu-devel] [RFC][PATCH v3 16/21] virtproxy: add option parser helper vp_parse(), Michael Roth, 2010/11/15
- Re: [Qemu-devel] [RFC][PATCH v3 16/21] virtproxy: add option parser helper vp_parse(),
Jes Sorensen <=
[Qemu-devel] [RFC][PATCH v3 17/21] virtproxy: add virtproxy-builtin.c for compat defs, Michael Roth, 2010/11/15
[Qemu-devel] [RFC][PATCH v3 18/21] virtproxy: qemu integration, add virtproxy chardev, Michael Roth, 2010/11/15
[Qemu-devel] [RFC][PATCH v3 21/21] virtproxy: Makefile/configure changes to build qemu-vp, Michael Roth, 2010/11/15
[Qemu-devel] [RFC][PATCH v3 19/21] virtproxy: qemu integration, add virtproxy to Makefile.targets, Michael Roth, 2010/11/15
[Qemu-devel] [RFC][PATCH v3 20/21] virtproxy: qemu-vp, main logic, Michael Roth, 2010/11/15
Re: [Qemu-devel] [RFC][PATCH v3 00/21] virtproxy: host/guest communication layer, Stefan Hajnoczi, 2010/11/16