[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH] block: fix the use of protocols in backing file
From: |
Kevin Wolf |
Subject: |
Re: [Qemu-devel] [PATCH] block: fix the use of protocols in backing files |
Date: |
Thu, 04 Nov 2010 13:54:03 +0100 |
User-agent: |
Mozilla/5.0 (X11; U; Linux x86_64; en-US; rv:1.9.1.12) Gecko/20100907 Fedora/3.0.7-1.fc12 Thunderbird/3.0.7 |
Am 27.10.2010 20:19, schrieb Anthony Liguori:
> Signed-off-by: Anthony Liguori <address@hidden>
>
> diff --git a/block.c b/block.c
> index 1a965b2..00b6f21 100644
> --- a/block.c
> +++ b/block.c
> @@ -603,10 +603,16 @@ int bdrv_open(BlockDriverState *bs, const char
> *filename, int flags,
> BlockDriver *back_drv = NULL;
>
> bs->backing_hd = bdrv_new("");
> - path_combine(backing_filename, sizeof(backing_filename),
> - filename, bs->backing_file);
> - if (bs->backing_format[0] != '\0')
> - back_drv = bdrv_find_format(bs->backing_format);
> + back_drv = bdrv_find_protocol(bs->backing_file);
> + if (!back_drv) {
If no protocol is specified, bdrv_find_protocol doesn't return NULL but
the file: driver.
This breaks all backing file related qemu-iotests cases because qcow2
backing files are opened as raw files now.
Kevin
- Re: [Qemu-devel] [PATCH] block: fix the use of protocols in backing files,
Kevin Wolf <=