[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-devel] Re: [PATCH v2][qemu-iotests] Improve test for qemu-img conv
From: |
Christoph Hellwig |
Subject: |
[Qemu-devel] Re: [PATCH v2][qemu-iotests] Improve test for qemu-img convert with backing file |
Date: |
Fri, 15 Oct 2010 23:11:09 +0200 |
User-agent: |
Mutt/1.3.28i |
On Fri, Oct 15, 2010 at 06:05:39PM +0200, Kevin Wolf wrote:
> Additionally to testing the qemu-img convert -B option, also test
> -o backing_file.
>
> Also, the old test acidentlly used a pattern of zeros for most of the writes,
> so that the allocation test didn't really work out. This is fixed by using an
> explicit pattern.
>
> Signed-off-by: Kevin Wolf <address@hidden>
> ---
> v2:
> - Include changes to 019.out to contain the expected output for the new
> script.
> The test still fails on git master, but that's a real qemu-img bug.
I'd rather wait adding more testing until it actually works. The
alternative would be to move the test for the new option into a separate
test case.