[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] Re: [PATCH] tcg: Fix compiler error (comparison of unsi
From: |
Blue Swirl |
Subject: |
Re: [Qemu-devel] Re: [PATCH] tcg: Fix compiler error (comparison of unsigned expression) |
Date: |
Wed, 13 Oct 2010 19:33:40 +0000 |
On Wed, Oct 13, 2010 at 7:22 PM, Hollis Blanchard <address@hidden> wrote:
> On Wed, Oct 13, 2010 at 11:58 AM, Stefan Weil <address@hidden> wrote:
>>
>> Hollis, do you still see problems with my patch?
>> Or can it be committed?
>
> I have no objection; I was just anticipating Blue's objection when I
> commented previously. It's just a style question really...
Both ((int)op >= 0 && op < NB_OPS) and ((unsigned int)op < NB_OPS)
produce same binary (if NB_OPS < MAX_INT). During the earlier, long
discussion, the int version was preferred.
[Qemu-devel] Re: [PATCH] tcg: Fix compiler error (comparison of unsigned expression), Blue Swirl, 2010/10/20