qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[Qemu-devel] Re: [PATCH 05/11] Delete write only variables


From: Paolo Bonzini
Subject: [Qemu-devel] Re: [PATCH 05/11] Delete write only variables
Date: Fri, 08 Oct 2010 19:28:34 +0200
User-agent: Mozilla/5.0 (X11; U; Linux x86_64; en-US; rv:1.9.2.9) Gecko/20100907 Fedora/3.1.3-1.fc13 Lightning/1.0b3pre Mnenhy/0.8.3 Thunderbird/3.1.3

On 10/07/2010 07:24 PM, Blue Swirl wrote:
>  On 10/06/2010 11:32 PM, Blue Swirl wrote:
>>
>>  @@ -91,8 +90,6 @@ static int vga_osi_call (CPUState *env)
>>            env->gpr[3] = 0;
>>            break;
>>        case 39: /* video_ctrl */
>>  -        if (env->gpr[6] == 0 || env->gpr[6] == 1)
>>  -            vga_vbl_enabled = env->gpr[6];
>>            env->gpr[3] = 0;
>>            break;
>>        case 47:
>
>  NACK, this smells like an incomplete emulation.
Why would we care about unfinished temporary Mac-on-Linux hack for
video.x? Perhaps the correct fix is to remove vga_osi_call function
and env->osi_call field entirely.

CCing the person who could answer.

Paolo



reply via email to

[Prev in Thread] Current Thread [Next in Thread]