[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-devel] Re: [PATCH 5/6] Switch migrate_set_speed() to take an 'o' a
From: |
Jes Sorensen |
Subject: |
[Qemu-devel] Re: [PATCH 5/6] Switch migrate_set_speed() to take an 'o' argument rather than a float. |
Date: |
Fri, 08 Oct 2010 10:50:07 +0200 |
User-agent: |
Mozilla/5.0 (X11; U; Linux x86_64; en-US; rv:1.9.2.9) Gecko/20100921 Fedora/3.1.4-1.fc13 Lightning/1.0b3pre Thunderbird/3.1.4 |
On 10/07/10 18:03, Paolo Bonzini wrote:
> On 10/07/2010 05:01 PM, address@hidden wrote:
>> diff --git a/hmp-commands.hx b/hmp-commands.hx
>> index 81999aa..95bdb91 100644
>> --- a/hmp-commands.hx
>> +++ b/hmp-commands.hx
>> @@ -754,7 +754,7 @@ ETEXI
>>
>> {
>> .name = "migrate_set_speed",
>> - .args_type = "value:f",
>> + .args_type = "value:o",
>> .params = "value",
>> .help = "set maximum speed (in bytes) for migrations",
> ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
>
> Is this still accurate?
>
> Alternatively, you said it's a mess to distinguish the defaults on the
> command line and the monitor, but is it harder than the attached patch?
I guess that depends on how you look at it, but I guess I could improve
the error message to make it clearer.
Cheers,
Jes
- [Qemu-devel] [PATCH v3 0/6] Introduce strtosz and make use of it, Jes . Sorensen, 2010/10/07
- [Qemu-devel] [PATCH 1/6] Introduce strtosz() library function to convert a string to a byte count., Jes . Sorensen, 2010/10/07
- [Qemu-devel] [PATCH 2/6] Support human unit formats in strtosz, eg. 1.0G, Jes . Sorensen, 2010/10/07
- [Qemu-devel] [PATCH 3/6] Add more error handling to strtosz(), Jes . Sorensen, 2010/10/07
- [Qemu-devel] [PATCH 4/6] Add support for 'o' octet (bytes) format as monitor parameter., Jes . Sorensen, 2010/10/07
- [Qemu-devel] [PATCH 5/6] Switch migrate_set_speed() to take an 'o' argument rather than a float., Jes . Sorensen, 2010/10/07
- [Qemu-devel] [PATCH 6/6] Remove obsolete 'f' double parameter type, Jes . Sorensen, 2010/10/07