[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-devel] Re: [PATCH] ds1225y: Fix compiler errors in debug code
From: |
Blue Swirl |
Subject: |
[Qemu-devel] Re: [PATCH] ds1225y: Fix compiler errors in debug code |
Date: |
Thu, 30 Sep 2010 20:09:11 +0000 |
On Thu, Sep 30, 2010 at 7:55 PM, Stefan Weil <address@hidden> wrote:
> Am 30.09.2010 21:37, schrieb Blue Swirl:
>>
>> On Thu, Sep 30, 2010 at 7:30 PM, Stefan Weil<address@hidden> wrote:
>>
>>>
>>> TARGET_FMT_lx is not allowed here, so use type casts to unsigned
>>> (which should be large enough to hold typical nvram addresses).
>>>
>>
>> The correct format is TARGET_FMT_plx.
>>
>
>
> addr is typically less than 8192 (size of nvram).
>
> TARGET_FMT_plx displays addr using 16 hex characters
> when the target has 64 bit addresses. That's correct but
> does not look pretty.
>
> Do you prefer TARGET_FMT_plx nevertheless?
We could also introduce a new format which does not perform zero padding.