[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-devel] Re: [PATCH 3/3] Add svm cpuid features
From: |
Roedel, Joerg |
Subject: |
[Qemu-devel] Re: [PATCH 3/3] Add svm cpuid features |
Date: |
Tue, 28 Sep 2010 11:28:52 +0200 |
User-agent: |
Mutt/1.5.20 (2009-06-14) |
On Mon, Sep 27, 2010 at 12:22:13PM -0400, Avi Kivity wrote:
> On 09/27/2010 05:40 PM, Roedel, Joerg wrote:
> > On Mon, Sep 27, 2010 at 11:02:23AM -0400, Avi Kivity wrote:
> > > On 09/27/2010 04:58 PM, Avi Kivity wrote:
> > > > On 09/27/2010 03:16 PM, Joerg Roedel wrote:
> > > >> This patch adds the svm cpuid feature flags to the qemu
> > > >> intialization path. It also adds the svm features available
> > > >> on phenom to its cpu-definition and extends the host cpu
> > > >> type to support all svm features KVM can provide.
> > > >>
> > > >
> > > > This should really be "all svm features" since we'll later mask them
> > > > with kvm capabilities. This way, if we later add more capabilities,
> > > > we automatically gain support in userspace.
> >
> > Yes, that is what -cpu host does with these patches applied. The
> > svm_features variable is set to -1 in this case and masked out later
> > with the KVM capabilities.
> >
>
> Well, running current uq/master I get:
>
> has_svm: can't execute cpuid 0x8000000a
> kvm: no hardware support
>
> ?
Weird, it worked here as I tested it. I had it on qemu/master and with
all three patches. But patch 1 should not make the difference. I take a
look, have you pushed the failing uq/master? What was your command line?
Joerg
--
AMD Operating System Research Center
Advanced Micro Devices GmbH Einsteinring 24 85609 Dornach
General Managers: Alberto Bozzo, Andrew Bowd
Registration: Dornach, Landkr. Muenchen; Registerger. Muenchen, HRB Nr. 43632
- [Qemu-devel] [PATCH 0/3] SVM feature support for qemu v3, Joerg Roedel, 2010/09/27
- [Qemu-devel] [PATCH 2/3] Set cpuid definition to 0 before initializing it, Joerg Roedel, 2010/09/27
- [Qemu-devel] [PATCH 1/3] Make kvm64 the default cpu model when kvm_enabled(), Joerg Roedel, 2010/09/27
- [Qemu-devel] [PATCH 3/3] Add svm cpuid features, Joerg Roedel, 2010/09/27
- [Qemu-devel] Re: [PATCH 3/3] Add svm cpuid features, Avi Kivity, 2010/09/27
- [Qemu-devel] Re: [PATCH 3/3] Add svm cpuid features, Avi Kivity, 2010/09/27
- [Qemu-devel] Re: [PATCH 3/3] Add svm cpuid features, Roedel, Joerg, 2010/09/27
- [Qemu-devel] Re: [PATCH 3/3] Add svm cpuid features, Avi Kivity, 2010/09/27
- [Qemu-devel] Re: [PATCH 3/3] Add svm cpuid features,
Roedel, Joerg <=
- [Qemu-devel] Re: [PATCH 3/3] Add svm cpuid features, Avi Kivity, 2010/09/28
- [Qemu-devel] Re: [PATCH 3/3] Add svm cpuid features, Roedel, Joerg, 2010/09/28
- [Qemu-devel] Re: [PATCH 3/3] Add svm cpuid features, Avi Kivity, 2010/09/28