[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH] e1000: Pad short frames to minimum size (60 byt
From: |
Kevin Wolf |
Subject: |
Re: [Qemu-devel] [PATCH] e1000: Pad short frames to minimum size (60 bytes) |
Date: |
Mon, 20 Sep 2010 10:50:40 +0200 |
User-agent: |
Mozilla/5.0 (X11; U; Linux x86_64; en-US; rv:1.9.1.12) Gecko/20100907 Fedora/3.0.7-1.fc12 Thunderbird/3.0.7 |
Am 19.09.2010 08:36, schrieb Stefan Hajnoczi:
> On Sat, Sep 18, 2010 at 10:27 PM, Edgar E. Iglesias
> <address@hidden> wrote:
>> This doesn't look right. AFAIK, MAC's dont pad on receive.
>
> I agree. NICs that do padding will do it on transmit, not receive.
> Anything coming in on the wire should already have the minimum length.
>
> In QEMU that isn't true today and that's why rtl8139, pcnet, and
> ne2000 already do this same padding. This patch is the smallest
> change to cover e1000.
What's the reason that it isn't true in QEMU today? Shouldn't we fix
these problems rather than making device emulations incorrect to
compensate for it?
Kevin
- Re: [Qemu-devel] [PATCH] e1000: Pad short frames to minimum size (60 bytes), (continued)
- Re: [Qemu-devel] [PATCH] e1000: Pad short frames to minimum size (60 bytes), Edgar E. Iglesias, 2010/09/18
- Re: [Qemu-devel] [PATCH] e1000: Pad short frames to minimum size (60 bytes),
Kevin Wolf <=
- Re: [Qemu-devel] [PATCH] e1000: Pad short frames to minimum size (60 bytes), Edgar E. Iglesias, 2010/09/20
- Re: [Qemu-devel] [PATCH] e1000: Pad short frames to minimum size (60 bytes), Stefan Hajnoczi, 2010/09/20
- Re: [Qemu-devel] [PATCH] e1000: Pad short frames to minimum size (60 bytes), Michael S. Tsirkin, 2010/09/20
- Re: [Qemu-devel] [PATCH] e1000: Pad short frames to minimum size (60 bytes), Anthony Liguori, 2010/09/20
- Re: [Qemu-devel] [PATCH] e1000: Pad short frames to minimum size (60 bytes), Edgar E. Iglesias, 2010/09/20
- Re: [Qemu-devel] [PATCH] e1000: Pad short frames to minimum size (60 bytes), Michael S. Tsirkin, 2010/09/20
- Re: [Qemu-devel] [PATCH] e1000: Pad short frames to minimum size (60 bytes), Michael S. Tsirkin, 2010/09/20
- [Bug 638955] Re: [Qemu-devel] [PATCH] e1000: Pad short frames to minimum size (60 bytes), Edgar E. Iglesias, 2010/09/20
- Re: [Qemu-devel] [PATCH] e1000: Pad short frames to minimum size (60 bytes), Michael S. Tsirkin, 2010/09/21
- Re: [Qemu-devel] [PATCH] e1000: Pad short frames to minimum size (60 bytes), Edgar E. Iglesias, 2010/09/21