[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH] Remove wrong semicolon in macro definition
From: |
Edgar E. Iglesias |
Subject: |
Re: [Qemu-devel] [PATCH] Remove wrong semicolon in macro definition |
Date: |
Tue, 14 Sep 2010 17:19:14 +0200 |
User-agent: |
Mutt/1.5.20 (2009-06-14) |
On Mon, Sep 13, 2010 at 09:21:57PM +0200, Stefan Weil wrote:
> Macros normally should not end with a semicolon,
> otherwise their usage results in two statements
> where only one statement was expected.
Applied
>
> Signed-off-by: Stefan Weil <address@hidden>
> ---
> hw/serial.c | 4 ++--
> tests/cris/check_swap.c | 2 +-
> 2 files changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/hw/serial.c b/hw/serial.c
> index 49431b2..f09ce0a 100644
> --- a/hw/serial.c
> +++ b/hw/serial.c
> @@ -101,10 +101,10 @@
>
> #ifdef DEBUG_SERIAL
> #define DPRINTF(fmt, ...) \
> -do { fprintf(stderr, "serial: " fmt , ## __VA_ARGS__); } while (0);
> +do { fprintf(stderr, "serial: " fmt , ## __VA_ARGS__); } while (0)
> #else
> #define DPRINTF(fmt, ...) \
> -do {} while(0);
> +do {} while (0)
> #endif
>
> typedef struct SerialFIFO {
> diff --git a/tests/cris/check_swap.c b/tests/cris/check_swap.c
> index 743cfc5..824a685 100644
> --- a/tests/cris/check_swap.c
> +++ b/tests/cris/check_swap.c
> @@ -41,7 +41,7 @@ do { \
> cris_tst_mov_cc(n, z); \
> if (r != expected) \
> err(); \
> -} while(0);
> +} while(0)
>
> void check_swap(void)
> {
> --
> 1.7.0.4
>
>