[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-devel] [PATCH] mips_fulong2e: Detect format errors for function pr
From: |
Stefan Weil |
Subject: |
[Qemu-devel] [PATCH] mips_fulong2e: Detect format errors for function prom_set |
Date: |
Sat, 11 Sep 2010 08:46:24 +0200 |
Add the necessary gcc attribute and fix the detected errors.
Cc: Aurelien Jarno <address@hidden>
Signed-off-by: Stefan Weil <address@hidden>
---
hw/mips_fulong2e.c | 8 +++++---
1 files changed, 5 insertions(+), 3 deletions(-)
diff --git a/hw/mips_fulong2e.c b/hw/mips_fulong2e.c
index cbe7156..2ef5070 100644
--- a/hw/mips_fulong2e.c
+++ b/hw/mips_fulong2e.c
@@ -77,6 +77,8 @@ static struct _loaderparams {
} loaderparams;
static void prom_set(uint32_t* prom_buf, int index, const char *string, ...)
+ __attribute__ ((format (gnu_printf, 3, 4)));
+static void prom_set(uint32_t* prom_buf, int index, const char *string, ...)
{
va_list ap;
int32_t table_addr;
@@ -141,13 +143,13 @@ static int64_t load_kernel (CPUState *env)
prom_size = ENVP_NB_ENTRIES * (sizeof(int32_t) + ENVP_ENTRY_SIZE);
prom_buf = qemu_malloc(prom_size);
- prom_set(prom_buf, index++, loaderparams.kernel_filename);
+ prom_set(prom_buf, index++, "%s", loaderparams.kernel_filename);
if (initrd_size > 0) {
- prom_set(prom_buf, index++, "rd_start=0x" PRIx64 " rd_size=%li %s",
+ prom_set(prom_buf, index++, "rd_start=0x%" PRIx64 " rd_size=%li %s",
cpu_mips_phys_to_kseg0(NULL, initrd_offset), initrd_size,
loaderparams.kernel_cmdline);
} else {
- prom_set(prom_buf, index++, loaderparams.kernel_cmdline);
+ prom_set(prom_buf, index++, "%s", loaderparams.kernel_cmdline);
}
/* Setup minimum environment variables */
--
1.7.0.4
- [Qemu-devel] [PATCH] mips_fulong2e: Detect format errors for function prom_set,
Stefan Weil <=
- [Qemu-devel] [PATCH] mips_malta: Detect format errors for function prom_set, Stefan Weil, 2010/09/11
- [Qemu-devel] [PATCH 1/2] Add support for gcc format attribute gnu_printf, Stefan Weil, 2010/09/13
- Re: [Qemu-devel] [PATCH 1/2] Add support for gcc format attribute gnu_printf, Blue Swirl, 2010/09/20
- [Qemu-devel] [PATCH] Move macros GCC_ATTR and GCC_FMT_ATTR to common header file, Stefan Weil, 2010/09/20
- [Qemu-devel] Re: [PATCH] Move macros GCC_ATTR and GCC_FMT_ATTR to common header file, Stefan Weil, 2010/09/21
- [Qemu-devel] [PATCH] Move macros GCC_ATTR and GCC_FMT_ATTR to common header file, Stefan Weil, 2010/09/21
- [Qemu-devel] Re: [PATCH] Move macros GCC_ATTR and GCC_FMT_ATTR to common header file, Blue Swirl, 2010/09/21
- [Qemu-devel] [PATCH] Move macros GCC_ATTR and GCC_FMT_ATTR to common header file, Stefan Weil, 2010/09/21
- [Qemu-devel] Re: [PATCH] Move macros GCC_ATTR and GCC_FMT_ATTR to common header file, Blue Swirl, 2010/09/22
- Re: [Qemu-devel] [PATCH 1/2] Add support for gcc format attribute gnu_printf, Stefan Weil, 2010/09/20