|
From: | Anthony Liguori |
Subject: | Re: [Qemu-devel] Re: [PATCH 5/5] RFC: distinguish warm reset from cold reset. |
Date: | Tue, 31 Aug 2010 08:08:17 -0500 |
User-agent: | Mozilla/5.0 (X11; U; Linux x86_64; en-US; rv:1.9.1.11) Gecko/20100713 Lightning/1.0b1 Thunderbird/3.0.6 |
On 08/30/2010 09:58 PM, Isaku Yamahata wrote:
I was thinking that we should stick entirely within the qdev abstraction. The patchset I sent out introduced a cold reset as a qdev property on the devices. For warm reset, if I understand correctly, we need two things. We need to 1) control propagation order and we need to 2) differentiate per-device between cold reset and warm reset. For (2), I don't know that we truly do need it. For something like PCI AER, wouldn't we just move the AER initialization to the qdev init function and then never change the AER registers during reset? IOW, the only way to do a cold reset would be to destroy and recreate the device.I'm lost here. Then, what should qdev_reset() do?
I don't know, that's what I'm trying to understand.As of this moment, you've convinced me that it should be a warm reset. However, I'm not yet convinced that we need to allow buses to change the propagation path of the warm reset.
Regards, Anthony Liguori
[Prev in Thread] | Current Thread | [Next in Thread] |