Re: [Qemu-devel] Re: [PATCH 11/14] Remove unused function arguments

qemu-devel

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] Re: [PATCH 11/14] Remove unused function arguments

From:	Anthony Liguori
Subject:	Re: [Qemu-devel] Re: [PATCH 11/14] Remove unused function arguments
Date:	Mon, 30 Aug 2010 12:13:38 -0500
User-agent:	Mozilla/5.0 (X11; U; Linux x86_64; en-US; rv:1.9.1.11) Gecko/20100713 Lightning/1.0b1 Thunderbird/3.0.6

On 08/30/2010 11:24 AM, Paolo Bonzini wrote:

On 08/30/2010 05:35 PM, address@hidden wrote:

From: Jes Sorensen<address@hidden>


I think it's better to leave ctxt in for future extensibility.

You can mark it as __attribute__((unused)) to suppress the warning.


That seriously ugifies the code IMHO.

Regards,

Anthony Liguori

Paolo

[Prev in Thread]

Current Thread

[Next in Thread]

Re: [Qemu-devel] Re: [PATCH 10/14] Zero json struct with memset() instea of = {} to keep compiler happy., (continued)
- [Qemu-devel] [PATCH 11/14] Remove unused function arguments, Jes . Sorensen, 2010/08/30
  - [Qemu-devel] Re: [PATCH 11/14] Remove unused function arguments, Paolo Bonzini, 2010/08/30
    - Re: [Qemu-devel] Re: [PATCH 11/14] Remove unused function arguments, Anthony Liguori <=
- [Qemu-devel] [PATCH 02/14] Respect return value from nbd_client(), Jes . Sorensen, 2010/08/30
- [Qemu-devel] [PATCH 13/14] Change DPRINTF() to do{}while(0) to avoid compiler warning, Jes . Sorensen, 2010/08/30
- [Qemu-devel] [PATCH 14/14] load_multiboot(): get_image_size() returns int, Jes . Sorensen, 2010/08/30
- [Qemu-devel] [PATCH 07/14] Remove unused argument for get_whole_cluster(), Jes . Sorensen, 2010/08/30
- [Qemu-devel] [PATCH 03/14] Fix repeated typo: was "end if list" instead of "end of list", Jes . Sorensen, 2010/08/30
- [Qemu-devel] [PATCH 04/14] Zero initialize timespec struct explicitly, Jes . Sorensen, 2010/08/30
  - [Qemu-devel] Re: [PATCH 04/14] Zero initialize timespec struct explicitly, Anthony Liguori, 2010/08/30
    - [Qemu-devel] Re: [PATCH 04/14] Zero initialize timespec struct explicitly, Jes Sorensen, 2010/08/30
    - Re: [Qemu-devel] Re: [PATCH 04/14] Zero initialize timespec struct explicitly, malc, 2010/08/30
    - Re: [Qemu-devel] Re: [PATCH 04/14] Zero initialize timespec struct explicitly, malc, 2010/08/30

Prev by Date: Re: [Qemu-devel] Re: [PATCH 10/14] Zero json struct with memset() instea of = {} to keep compiler happy.
Next by Date: Re: [Qemu-devel] Re: [PATCH 10/14] Zero json struct with memset() instea of = {} to keep compiler happy.
Previous by thread: [Qemu-devel] Re: [PATCH 11/14] Remove unused function arguments
Next by thread: [Qemu-devel] [PATCH 02/14] Respect return value from nbd_client()
Index(es):
- Date
- Thread