|
| From: | Gerd Hoffmann |
| Subject: | Re: [Qemu-devel] [PATCH v3 07/10] spice: add keyboard |
| Date: | Thu, 26 Aug 2010 08:55:14 +0200 |
| User-agent: | Mozilla/5.0 (X11; U; Linux x86_64; en-US; rv:1.9.2.7) Gecko/20100720 Red Hat/3.1.1-1.el6 Thunderbird/3.1.1 |
Hi,
+ + qemu_spice_input_init();Why not pass spice_server to qemu_spice_input_init() and avoid the global?
We need the global anyway for the guest devices (not yet in this series). They are created using -device. Thus the initialization functions are not called from spice code and we can't simply pass a reference to spice_server.
cheers, Gerd
| [Prev in Thread] | Current Thread | [Next in Thread] |