qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH 0/5] CODING_STYLE amendments


From: Avi Kivity
Subject: Re: [Qemu-devel] [PATCH 0/5] CODING_STYLE amendments
Date: Mon, 23 Aug 2010 14:07:11 +0300
User-agent: Mozilla/5.0 (X11; U; Linux x86_64; en-US; rv:1.9.2.7) Gecko/20100720 Fedora/3.1.1-1.fc13 Lightning/1.0b2pre Thunderbird/3.1.1

 On 08/23/2010 02:01 PM, Markus Armbruster wrote:
Avi Kivity<address@hidden>  writes:

  On 08/22/2010 07:40 PM, Jes Sorensen wrote:
I totally agree with Markus
that it seems like wasted effort to come up with new tools and having to
maintain them when there are good ones out there like the ones from the
Linux kernel.

scripts/Lindent is just a wrapper around indent(1).  We don't need to
come up with new tools, just come up with the right switches to
indent(1).
How can indent help effectively with policing the formatting of new
code, in the form of patches, without touching the old code?

It can't. We need something like checkpatch (but not checkpatch itself, that's much too whiny).

--
error compiling committee.c: too many arguments to function




reply via email to

[Prev in Thread] Current Thread [Next in Thread]