qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH 0/5] CODING_STYLE amendments


From: Avi Kivity
Subject: Re: [Qemu-devel] [PATCH 0/5] CODING_STYLE amendments
Date: Sun, 22 Aug 2010 23:03:54 +0300
User-agent: Mozilla/5.0 (X11; U; Linux x86_64; en-US; rv:1.9.2.8) Gecko/20100806 Fedora/3.1.2-1.fc13 Thunderbird/3.1.2

 On 08/22/2010 09:42 PM, Anthony Liguori wrote:

I'm strongly opposed to any reformatting of the tree.

I strongly second this statement.


All it does is break git blame which makes debugging harder without offering any real benefits.


Even worse, it makes backporting patches much harder.

Sometimes we have to refactor the code to introduce new features or fix deep deficiencies. Let's not do it just to change the code style.

--
I have a truly marvellous patch that fixes the bug which this
signature is too narrow to contain.




reply via email to

[Prev in Thread] Current Thread [Next in Thread]